https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marc Véron from comment #2)
Hi Jonathan
The patch minifies that false positives happen, but IMO the test will still arbitrarely fail with e.g. following dates:
got: '2017-08-10T20:53:59' expected: '2017-08-10T20:54:00'
Wouldn't it be safer to calculate the delta and pass the test OK if delta <60 sec? (Or even introduce a param for the precision that defaults to 60.)
Marc
The datetime should be mocked IMO. -- You are receiving this mail because: You are watching all bug changes.