https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38922 --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to David Cook from comment #23)
It appears that Janusz Kaczmarek and Roman Dolny are co-workers so Roman is not eligible to sign off Janusz's patches.
What we have in writing isn't that strict. https://wiki.koha-community.org/wiki/Development_workflow#Rules
Patch signer should not be patch writer. Preferably, patch writer and patch signer should not be from the same company or organisation.
And from what I recall from small talk at the hackfest, it feels more like Roman is a customer. But regardless of me remembering right or not, when looking at the commits in main, most Janusz's patches got a signoff from Roman. So even if they are not colleagues but just customer-providers, it would still be more healthy to have a diverse mix in where we get one's signoffs. That's where the "Preferably" of the rules could be read as blocking in the present case. So it's a matter of it not happening too much. It's not outright banned. Unless the rules are changed which I don't think it's needed IMHO. Maybe just to clarify though. @Roman thanks a lot for your signoff work. It's important to note that it goes beyond Janusz's patches just so we don't get a wrong idea of your work. Keeping signing off that many patches even if less from Janusz will still help their work due to making the queue more reasonable. @Janusz thanks for all your patches, it's very appreciated :) Regardless of current and future rules, there can still be a targeted effort from colleagues or customers to provide a second signoff (with some improvised additional testing written in a comment) to patches waiting QA. That would be a healthy way to help a patch go faster in the dev pipeline. -- You are receiving this mail because: You are watching all bug changes.