https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- QA scripts happy and the code all works as described. Two points to mention for RM however. 1) There's a small change of logic here regarding itemlost triggers. We now trigger on change from any lost value (any non zero) to not lost.. We used to only trigger for positive lost values to not lost. (I don't think this is an issue and couldn't find anything in the documentation to say we should be treating negatives differently however) 2) I feel like the code here is inconsistent with other Koha::Object based modules.. however, I can understand this as a stepping stone move.. -- You are receiving this mail because: You are watching all bug changes.