https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #15)
I see why y'all feel this should be completely arbitrary values: because it is only used for display purposes.
The catch is this options:
* phone * phonepro * mobile * email * emailpro * fax
refer to real `borrowers.*` columns, so my fear is at some point someone will want to tie the *selected prefered contact method* value on that column, to a real behavior/function in Koha.
So, thinking in advance, I feel like the current options should be presented a system-defined, which can also be disabled, and then we allow users to define their own.
'Do not contact' should be a default system option (value NULL).
One drawback for this particular implementation is the contact methods are translatable (templates) right now. Moving them to the AV table will make them not-translatable or have every non-english install need to manually tweak the introduced AVs.
+1 I've had the same feeling looking at this and I think it's a good idea. If people want to hide some entries, which makes sense as we allow to hide any patron field, we could inherit that from BorrowerUnwantedFields maybe or have a separate visibility setting. -- You are receiving this mail because: You are watching all bug changes.