https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43301 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivia.reynolds@openfifth.c | |o.uk --- Comment #1 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- I've definitely been baffled by the behaviour of this function before. I think the most confusing thing is the "spooky action at a distance" where if you add a library to a group it can get access to every resource not covered by that group: `if ( $library_groups->count )` is true but none of those groups match the relevant feature so no restrictions are added for them. I've experimented with making the behaviour more logical, but every change I've made has failed an explicit group permission test somewhere which makes me worry people depend on the current implementation. For example, `t/db_dependent/Koha/Patrons.t` line 1898 asserts that you can only see your library if it's not in a group, and line 1847 asserts you can see libraries outside of your group if that group doesn't have the relevant feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.