http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #75 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Katrin Fischer from comment #74)
I am still a bit torn about this patch and the new column. I think we need a follow up to clean up the sample files at least. Also the new field being mandatory means that you are forced to fill it in on editing now, but I see no way to get around that. Does it really need to be mandatory?
I don't think it needs to be mandatory, and I also think that if isocode is null, that it would be reasonable to fall back to checking for the main currency code/name (currency.currency) when parsing the prices. I'm willing to deal with that as an RM follow-up, but I would appreciate confirmation from the patch submitter that there's no issue with my proposed change. -- You are receiving this mail because: You are watching all bug changes.