http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 18463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18463 Bug 10374 - Clean up and unify CircControl related code Review of attachment 18463: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10374&attachment=18463) ----------------------------------------------------------------- This was the oldest bug that was "Patch does not apply", but since there are minor logic issues. I figure this commentary on them might spur a fix. ::: C4/Circulation.pm @@ +2249,5 @@
+ if ( $circcontrol eq 'PickupLibrary' ) { + if ( C4::Context->userenv && C4::Context->userenv->{branch} ) + { + $branch = C4::Context->userenv->{branch}; + } else {
If one is tweaking the if/else's, why not use a consistent style? Here it is "} else {" a few lines later "}" with "else {" on the next line. @@ +2265,5 @@
+ else { + $branch = $item->{ C4::Context->preference('HomeOrHoldingBranch') } + || $item->{homebranch}; + } + }
What happened to the else case? What if $circcontrol is not 'PickupLibrary', 'PatronLibrary', or 'ItemHomeLibrary'? -- You are receiving this mail because: You are watching all bug changes.