https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40473 Bug ID: 40473 Summary: X scale for Code39 barcodes is calculated incorrectly Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org While reviewing how "Barcode width" works as added by bug 10762, I noticed that the calculation of the X scale factor for Code39 barcodes is incorrect. If you specify a Barcode width of 1, you'd expect that to use 100% of the label width. But it doesn't. Now this isn't a problem introduced by Bug 10762, because Bug 10762 just replaced a hard-coded value of .8 with a editable value. It's a much older bug. Consider the following: $x_scale_factor = ( $params{'width'} / $tot_bar_length ); $params{'width'} is the "Barcode width" multiplied by the label width. This makes sense as it represents the total width that we're willing to use. The problem is $tot_bar_length. It uses an algorithm which is inconsistent with the algorithm used by PDF::Reuse::Barcode. But that's easy to fix! -- You are receiving this mail because: You are watching all bug changes.