https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #20)
Koha::Script does this: Might be that the author copied this part of the code?
Yes, copied from there
The sub _new_userenv stores a sessionID in activeuser (which is quite confusing). I would not recommend to always use session 1. (Session id is a varchar(32) btw.) Why not use "ILSDI_session", possibly followed by a few digits or so? Any recommendation on the digits? Use a timestamp or the same for each?
Another note: 11 parameters are passed in ilsdi.pl and Koha::Script. I only count 10. We're copy&pasting an error here. shift @_; # this is the object my ($usernum, $userid, $usercnum, $userfirstname, $usersurname, $userbranch, $branchname, $userflags, $emailaddress, $shibboleth)= [etc] # these are 10
Koha Script appears to be right, just a typo when changing to cron I think -- You are receiving this mail because: You are watching all bug changes.