https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Thanks! Couple issues: 1) you copy & paste the code inside the loop instead of abstracting it to a subroutine. Please fix this so the code is in a subroutine and performance problems like this can be prevented by seeing the problems immediately. This is important also for testability. 2) There should be one logical change per commit, leave "$can_item_be_reserved eq 'OK'" change in the && statement to another commit, and also leave "my $on_shelf_holds = Koha:: [...]" to another commit, plus any other changes I missed not related to fixing the O(n^2) issue here -- You are receiving this mail because: You are watching all bug changes.