https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22439 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201745&action=edit Bug 22439: (QA follow-up) Unify child record and analytics linking in addbiblio.pl cataloguing/addbiblio.pl had two near-identical blocks for building a new child MARC record and linking it to a host: one for "Create analytics" (hostbiblionumber/hostitemnumber, shown when EasyAnalyticalRecords is enabled) and one for "New child record" (parentbiblionumber, shown when it's disabled). Both ultimately called generate_marc_host_field, so this was duplication left over after the earlier consolidation. This merges them into a single block, treating hostbiblionumber as a request-param alias for parentbiblionumber rather than renaming the URL so existing links/bookmarks keep working. The "Create analytics" path now also gets the proper MARC21 leader template and SetMarcUnicodeFlag call that the "New child record" path already had, and gains a guard against an invalid parentbiblionumber that the old hostbiblionumber block lacked. Test plan: 1. Enable EasyAnalyticalRecords, use "Create analytics" from a record's Items tab, confirm the 773/461 is populated as before. 2. Disable EasyAnalyticalRecords, use "New child record", confirm the 773/461 is still populated as before. -- You are receiving this mail because: You are watching all bug changes.