https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40856 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186742|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186760&action=edit Bug 40856: Add unit tests for Standard backend metadata method This patch adds comprehensive unit tests for the metadata() method in the Standard ILL backend to establish baseline behavior before optimization. The tests cover: - Metadata structure (returns hashref) - Included attributes (title, author, isbn, year, custom fields) - Excluded attributes (ignored fields like requested_partners, type, etc.) - Display name transformation (attribute types become display names) Current behavior tested: - metadata() filters out predefined ignore list attributes - Uses linear search with grep for each attribute - Transforms attribute types to display names (title -> Title) - Custom fields get ucfirst transformation (custom_field -> Custom_field) - Returns hashref with display names as keys These tests document the current inefficient implementation and will ensure the upcoming optimization maintains compatibility. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/ILL/Backend/Standard.t => SUCCESS: Tests pass! Current metadata behavior documented 3. Tests establish baseline for upcoming optimization 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.