https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, looking at the patch I wonder why some classes seem to be missing: [%- IF display_patron_name -%] [%- IF data.category_type == 'I' -%] - [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] + <span class="surname">[%- data.surname | html %]</span> [% IF data.othernames %] <span class="othernames">([% data.othernames | html %])</span>[% END -%] [%- ELSIF invert_name -%] - [% data.title | $raw %][%- data.surname | html %], [% data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END -%] + [% data.title | $raw %][%- data.surname | html %], <span class="firstname">[% data.firstname | html %]</span> [% IF data.othernames %] ([% data.othernames | html %]) [% END -%] Here the surname could have a class as well, to keep things consistent. [%- ELSE -%] - [% data.title | $raw %][%- data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END %] [% data.surname | html -%] + [% data.title | $raw %]<span class="firstname">[%- data.firstname | html %]</span> [% IF data.othernames %]<span class="othernames">([% data.othernames | html %])</span> [% END %]<span class="surname"> [% data.surname | html -%]</span> Should we add a class for title as well? -- You are receiving this mail because: You are watching all bug changes.