http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 Bug ID: 11206 Summary: Factorize code for getting orders in C4::Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org A lot of subs are used in C4::Acquisitions for doing basically the same thing : searching orders. Code can be factorized, to improve maintainability, build stronger unit tests, and make further improvements easier (like using DBIx::Class, or Bug 10758 ( Show bibliographic information of deleted records in acquisitions). First draft patch attached here. Fully testable, but can maybe be improved, and UT are not written yet. To test : make a full acquisition workflow, search orders, display uncertain prices, export baskets, basketgroups and late orders in CSV or PDF when possible. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.