https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #29)
The only bit that raised slight alarm bells.. but that's only because my email understanding isn't at 'expert god level' is the internal content type of the attachments being hardcoded to `application/octet-stream`.. in all my testing I couldn't find a problem with that.. but I don't understand it either so would love a comment from Tomas explaining?
Good catch, Martin. I'll post a follow-up patch for that. application/octet-stream is the fallback in Email::Stuffer when it cannot make a better guess on the content. I overlooked it because the email clients I tested didn't care about that and displayed things correctly. But we should explicitly pass text/plain. -- You are receiving this mail because: You are watching all bug changes.