https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161 --- Comment #53 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens (kidclamp) from comment #51)
Hidden in opac in Koha Biblio doesn't check OpacHiddenItemsHidesRecord, it should. It should also use filter_by_visible rather than looping items, just for simplicity. It should also check if record is suppressed as we're only catching hidden item hiding this way.
Except that Koha::Biblio->hidden_in_opac does check OpacHiddenItemsHidesRecord ;). Good point about filter_by_visible_in_opac. It's a good idea not only because of simplicity but also performance. I think that would be an optimization though. Funny story. In my local version, I do look for OpacSuppression as well. I didn't include it here, because I figured it was out of scope haha. I was going to do it as a follow-up.
Neither of our patches actually triggers a record change, so partial harvests (changes since) won't pickup the difference.
Hmm touché. I suppose that means that the deleted record would show up in subsequent changes... but also all subsequent changes. Hmm... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.