https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42085 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The log viewer now (with release notes| |dependent changes) shows | |the details for a deleted | |borrower in the info and | |diff columns - including | |the permissions they had | |before the patron account | |was deleted. Previously, no | |details were recorded - | |just that a patron with | |their borrower number was | |deleted. | | | |This may be helpful for | |auditing purposes (for | |example, a previous | |employee's account was | |decommissioned, and they | |had XYZ permissions at the | |time). CC| |david@davidnind.com --- Comment #11 from David Nind <david@davidnind.com> --- Not sure that I got the release note right (with all the dependent patches). Testing notes (using KTD): 1. For a staff patron (I used Henry): 1.1 Add a permission (I added: Staff access, allows viewing of catalogue in staff interface (catalogue)) 1.2 Change details for their account (for example, add a middle name) 1.3 Delete the patron account 2. In the log viewer, show the Diff column (Columns > Diff). 3. In the log viewer, note that: [1] 3.1 The patron account details change in 1.2 is logged 3.2 The patron account deletion is logged, but no details are recorded 3.3 The permission changes are not logged. 3.4 As there are no details recorded when the patron is deleted, there is no record of the permissions they had. 4. Apply the patches and restart everything (restart_all). 5. Change a patron so that they are a staff patron (I used Mary) 6. For the staff patron, repeat the steps in step 1 7. In the log viewer, note that there are now entries in the Diff column for all the changes made (there are also additional details logged in the info column) 8. The info and diff columns for the patron account deletion now shows the permissions they had at the time the account was deleted 8.1 Info column: ..."permissions" : { "catalogue" : 1 }... 8.2 Diff column: ..."permissions" : { "R" : { "catalogue" : 1 } }... 9. The tests pass: prove t/db_dependent/Koha/Patrons.t [1] Log viewer entries before the patch: Patrons Delete 19 Staff interface Patrons Modify 19 { "middle_name" : { "after" : "James", "before" : null } } Staff interface -- You are receiving this mail because: You are watching all bug changes.