http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Jonathan Druart from comment #4)
I disagree with this patch. I understand the problem, but this patch does not fix it in the right way. It does not make sense to add the mtt param to the "delete" link. Indeed, we will delete all mtt for a given letter.
A better fix would be to change the getletter behavior to default on "email", but return the first letter if the email template has not been created.
I agree with your comment, personally I wasn't happy doing it this way, but wasn't sure if it would be OK to mess with an 'in-use' Letters.pm So, you suggest that I should focus on: sub getletter { my ( $module, $code, $branchcode, $message_transport_type ) = @_; $message_transport_type ||= 'email'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.