https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #5)
Created attachment 83252 [details] [review] Bug 21747: Use Koha::Account:: routines in UpdateFine
Set to use Koha::Account->add_debit and Koha::Account::Line->adjust
Known Side Effect: The format of the FinesLog, if enabled, is changed after this patch. Prior to this patch the $actionname was left undefined and the $infos field contained the string:
`"due=".$due." amount=".$amount." itemnumber=".$itemnum`
After this patch, the logs are more consistent with other FINES logs, with an $actionname of 'CREATE' or 'UPDATE' and the $infos field containing a Dumper of fine data.
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
I think we need to consider the backdated returns use case, and have another offset for those, as fine_increment doesn't look right. -- You are receiving this mail because: You are watching all bug changes.