http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597 --- Comment #13 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Srdjan Jankovic from comment #12)
Since I was kindly ask to take part in this discussion:
* Koha::Log lacks a bit in the Synopsis department, especially examples how to use it within Koha:: (object) and C4 (procedural) namespaces
Have you read http://wiki.koha-community.org/wiki/Koha_Logger ? I would be happy to expand it if what I've written is not sufficient!
* I don't mind the way it is used. If the decision was made to go with Log::Log4perl, then this is along its lines. An alternative would be to create a log object in context, and use it. Both have pros and cons. I do like the idea of having log category per request (one logger in context) as opposed to per function (which is the case with this patch). A more complete solution would be to add a mechanism to add to category, so in this case whole request would be eg marc-import, and this particular category would be marc-import.C4.ImportBatch.BatchRevertRecords
I don't think that would work for log4perl for the reasons I've outlined. Basically, if we had a singleton logger instance it would have a fixed namespace per request, and we'd lose all the power log4perl gives us. If I'm misunderstanding anything please let me know! -- You are receiving this mail because: You are watching all bug changes.