https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Code changes look good to me. Fixed test in a follow-up. The only thing remaining is the discussion about the rounding (changing from floor to ceil). I will pass QA if we change it back for current behavior. If we do not want to change it, please provide evidence for community consensus about that change. You could do so by mailing the lists or putting on the dev meeting agenda, etc. Putting on ID for now. -- You are receiving this mail because: You are watching all bug changes.