https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #58)
(In reply to Pedro Amorim from comment #57)
(In reply to Victor Grousset/tuxayo from comment #55)
This new file needs a /* keep tidy */ comment on top: koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js
It's also a good opportunity to add a /* keep tidy */ comment on top of this file: koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js To avoid having to manually check it with prettier.
No api.js files under js/vue/fetch have this.
JS14 guideline is more recent (march) than these. So it's case of dealing with legacy JS/TS/vue files. «Older JS files should also strive to become tidier and eventually all end up with the keep tidy header line too.» It's just that in the meantime they haven't been touched or this guideline was forgotten.
If this is reason to FQA it should at least be flagged by the QA script first then.
The point of /* keep tidy */ is to opt in the QA script enforcement of JS14. That's how to deal with the old files that are totally not compliant. (so not checked by default) So until they are pretty and /* keep tidy */ is added, they will never show up in the QA script. At least not for this check.
Not sure to follow the discussion, just want to confirm that .js files under koha-tmpl/intranet-tmpl/prog/js/vue do not need the 'keep tidy' flag, but are checked by both the QA script and unit test (xt/vue_tidy.t) -- You are receiving this mail because: You are watching all bug changes.