https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Cook from comment #48)
(In reply to Jonathan Druart from comment #47)
Everything looks fine to me. However I think it would be good to handle a wrong or non-existent patron category or branchcode (GoogleOpenIDConnectDefaultCategory and GoogleOpenIDConnectDefaultBranch). Usually I am not in favour of over-checking everything but it sounds like it is needed here (in order to avoid the 500).
I still think it's a shame that we hard-coded "Google" into the system preferences, when OpenIDConnect can be implemented by other providers, but I think I'm flogging a dead horse on that one...
Not introduced by this patch set, they use the existing pattern. -- You are receiving this mail because: You are watching all bug changes.