https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 61645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61645&action=edit Bug 18339: Remove ->opac_editable ->opac_display from Koha::Patron::Attribute Trying to simplify the implementation of 13757, I replaced some legacy code in favour of a Koha::Object-based implementation for the OPAC controller scripts. On doing so I went too far with this methods, as what was needed was a way to retrieve the type of the attribute and ask it about such properties. This patch removes those methods, its tests, and replaces its uses in the codebase like this: $attribute->opac_editable for $attribute->type->opac_editable To test: - Run $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests still pass - Try changing the opac_editable and opac_display properties and play in the OPAC with those attributes. Verify that everything works as expected. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.