http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, 0) The QA script fails: FAIL misc/migration_tools/import_lexile.pl FAIL critic I/O layer ":utf8" used at line 39, column 1. Use ":encoding(UTF-8)" to get strict validation. FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK pod OK valid 1) Is copyright 2013 correct? 2) I am not sure what one of the options means from the description, could you clarify? + --source-value Defines the value to put stored in the "Source" subfield ( default: "Lexile" ) 3) The documentation for --file says: "acquired from Lexile.com", but the actual file format is not documented. I think maybe we need to decide here if this is a vendor specific or a general purpose script. If it's vendor specific, we might want to reflect that more clearly in the file name and description. If it's general purpose, we should include notes about the file format to make this easier to reuse. 4) We didn't really finish our discussions about the standard options for CLI scripts (http://wiki.koha-community.org/wiki/Coding_Guidelines#Command-line_argument_...), but maybe this should have a -c for confirming the action as it's going to change data? -- You are receiving this mail because: You are watching all bug changes.