https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Emily Lamancusa from comment #2)
Submitting for feedback - this seems to work, but there are a couple of things I'm not sure about: - I kept the uri TT filters from the existing code. Should those be changed to html instead since they're not being passed in the URL anymore?
- I feel like there has to be a better way to handle the dependency between the .inc file and the JS file, but including the JS asset directly in the .inc file breaks things (I think because the include is added in the middle of the page in request.tt, which violates the coding guideline of including JS assets at the end?)
I don't have any feedback on these points, as I don't know enough to knowledgeably comment 8-) However, I have signed off the bug, as I can replicate the issue and it is fixed as per the test plan. -- You are receiving this mail because: You are watching all bug changes.