https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23849 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #25)
Victor, yes it's the correct file. I am sorry but those comments are hard to read, you should apply the patches and provide patches on top. IMO that will be more readable.
Ok, I'll try to integrate the content of my comments via patches. I wasn't confident enough to change the patches (fear of "corrupting" your work) And I'm still wondering how to deal with the many "categories" that I needed to do in my long comment. Thought thanks to the responses from Katrin and you, now I don't need that many categories.
Basically the ones marked with "> No" are the ones I processed already, so no need to talk more about them, unless you find something wrong (ie. marked as No but should be shared, however I am pretty sure there is no error on them).
I'll double check my list of potential false positives. Because I included those not having a privacy risk. Because I'm much less competent about the usefulness.
Work to be done (on top of the patches/files): 1. Identify the "Not sure" and give your opinion
ok
[...] 4. (optional) Do the same work for the new prefs added since I worked on this (19.06.00.044 - f4254cca37)
This is great, you got the exact version!! :D That's what I didn't know how to reliably find.
5. Remove the "no" (and "not sure") and provide a patch for Hea.
Thanks for the plan! -- You are receiving this mail because: You are watching all bug changes.