https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 52217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52217&action=edit Bug 16441: Do not use a package variable to cache C4::Letters::getletter C4::Letters::getletter use a package variable (%letter) to cache letter returned by the subroutine. I have not found any direct issues caused by that but it is safer to remove it. It won't be a big deal to hit the DBMS to get a valid letter when needed. No test plan here, just confirm that the changes make sense. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Confirm that performance loss is just a millisecond or so per subsequent call of getletter. -- You are receiving this mail because: You are watching all bug changes.