https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> ---
Hmm, I slightly wonder if it's a good idea to allow passing credit_number and allowing it to override the AudoCreditNumber setting.. to me if it's set then we should throw an Exception if someone is trying to pass in their own?
Since credit_number can only be automatically generated, it does not make sense to check if it's defined or not, so I can remove this check and always autogenerate a value. I can also throw an exception. To me, both solutions are acceptable. I'll let you pick the one you prefer ;)
The second question here.. should this apply to ALL credit types, or just a subset of those that actually deal with taking money as apposed to writeoffs and other types of giving credit (like LOST_ITEM_RETURN)?
I don't know, but the answer is probably... it depends :) Should I add a "Auto generate credit number" parameter in credit types ? -- You are receiving this mail because: You are watching all bug changes.