https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Cook from comment #19)
Comment on attachment 94807 [details] [review] Bug 23068: Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
Review of attachment 94807 [details] [review]: -----------------------------------------------------------------
::: C4/Context.pm @@ +1107,5 @@
+ +=cut + +sub set_remote_address { + if ( C4::Context->config('koha_trusted_proxies') ) {
Wouldn't this still be called under Plack?
Couldn't we just look to see if it's Plack via environmental variables and only do this for CGI?
Actually, it only gets called under plack at startup, since C4::Auth is loaded at that time. So, yes, we could do that, but it doesn't actually hurt performance by any meaningful metric! -- You are receiving this mail because: You are watching all bug changes.