http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * 1st, a question = This page just keep track of exchange rates, and does nothing on acquisition, right ? Do you plan to add this feature soon or later ? * ex_rates => the name of the table is unclear (what does 'ex' mean ? it's unclear that it's exchange, and does not contain currency). currency_exchange_history or something like that would be much more clear * If I read your patch correctly, you save the history only on a modif, with the new value. That's OK if you keep track of current rate in updatedatabase: when upgrading, the current rate should be set in this table, with a timestamp of 2000-01-01, to show what was the rate before we change it for the 1st time. Failing QA for #2 and #3 -- You are receiving this mail because: You are watching all bug changes.