https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Pedro Amorim from comment #20)
Thanks for the review, Victor. I believe my follow-ups address the issues you mentioned.
Confirmed :) After rereading, it seem to comply with coding guidelines.
Additional comments: I believe sub under at REST/V1/Auth.pm handles the use cases you mentioned, this is why removing e.g. HTTP code 400 from the additional_fields route spec specifically does not prevent a 400 response from that specific route, as that is "called before every request to API" as in the sub description. I believe we add this "dead API code" for every new endpoint for openAPI documentation purposes i.e. https://api.koha-community.org/
Good point, we can see that as documentation. (In reply to Tomás Cohen Arazi from comment #25)
This is a plural endpoint. Meaning it is expected to return an array. An empty one if the query returns no results.
Great, the rule is as simple as that. -- You are receiving this mail because: You are watching all bug changes.