https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #46)
Adding here some notes about the dependent tree (I've squashed the whole tree for pre-review):
1. - $messages->{'WasTransfered'} = 1; + $messages->{'WasTransfered'} = $tbr;
but
t/db_dependent/SIP/Transaction.t: is_deeply($result,{ messages => { 'NotIssued' => $item->barcode, 'WasTransfered' => 1 } },"Messages show not issued and transferred");
So I ran the tests and there is a failure:
# Failed test 'Messages show not issued and transferred' # at t/db_dependent/SIP/Transaction.t line 327. # Structures begin differing at: # $got->{messages}{TransferTrigger} = 'ReturnToHome' # $expected->{messages}{TransferTrigger} = Does not exist # Looks like you planned 5 tests but ran 2.
Fixed on the gitlab branch: Two follow-ups on bug 24446, the first fixes the test above by adding the 'TransferTrigger' into the is_deeply comparison. I've checked in SIP and the message is silently ignored further down the call chain. Second follow-up fixes a logical issue that was highlighted by the new test that was introduced since I wrote the code.. nice catch :) -- You are receiving this mail because: You are watching all bug changes.