http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #2)
- Setting parameters to undef if they were not defined was unnecessary bloat and obscuration
I disagree, it is not that the original code does. $t ||= undef and $t //= undef is not the same. The second one is unnecessary, not the first one. The original code says: if a variable ($basketcontractnumber, $deliveryplace or $billingplace) is equal to 0 or an empty string, we call ModBasketHeader with an undefined value. If someone calls the routine with "", we want to insert undef, not "" -- You are receiving this mail because: You are watching all bug changes.