https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39657 --- Comment #17 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #16)
OK, I'm passing QA here.. but I do wonder a little about when we should be just allowing 'x-koha-override' headers and when we should actually require a confirmation as the checkouts endpoint does.
With this case, the API consumer could just always opt to pass x-koha-override=any or list all the overrides with any request and as such, we're not actually blocking anything.
Just FTR, as we already chatted about this: I think in its current design this endpoint could be extended with the `confirmation flow` in a pretty straight-forward way. That said, the system we are calling the API from (Aspen) is asking Koha to actually *block* the requests. We are adding the individual overrides just so other API consumers can recreate the previous behavior if they find the need for that. Martin: if you think the confirmation flow is desirable for holds, please file a follow-up bug and I will be more than happy to give it a shot. -- You are receiving this mail because: You are watching all bug changes.