http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #16)
If I have enabled email and sms for a patron, but I have no email address and the SMS driver should fail, I have two messages in the queue that fall back to PREDUE print. In this case you will have print duplicates. (Two runs now create four PREDUE prints.)
This has already been raised by Olli, he opened a report, bug 11561. (In reply to M. de Rooy from comment #17)
Similarly, if I clear the SMS number, sms messages will be sent to the queue each time in status pending. They will fail only if process cronjob has been run.
Yes, a test could be added somewhere. But it should not append (yes you can via the UI, but it is a configuration issue). (In reply to M. de Rooy from comment #19)
I have some doubts on this patch: It could block lots of sms messages. You write: The sms part for DUE and PREDUE should not contain dynamic parts, only a standard message. But how do you prevent that (maybe apart from truncating the message to 160 chars)? If a message for a hold or a due does not contain a reference to the title, is it still useful for a patron at all? I could imagine that you send one message for dues at cronjob time, but what about Hold filled? Wouldn't that be a candidate for sending more messages if applicable?
Maybe could I add a condition in the sql query like " AND content = $message->{content}". Like that, if the template contains dynamic parts, that won't match. What do you think about that? -- You are receiving this mail because: You are watching all bug changes.