https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42582 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199168&action=edit Bug 42582: Fix Uncaught TypeError on 'Place request with partner libraries' This patch fixes an Uncaught TypeError on Place request with partner libraries (op=generic_confirm) when at least one partner library is available (primary email is set) and system preference ILLCheckAvailability is enabled. Reason for this is an undefined object services. Test plan: a) start a ktd instance ktd --proxy --name main up -d b) enable system preference ILLModule and ILLCheckAvailability http://main-intra.localhost/cgi-bin/koha/admin/preferences.pl?tab=interlibra... ILLModule: 'enable' ILLCheckAvailability: 'check' c) edit an ILL patron and set an Primary email address: http://main-intra.localhost/cgi-bin/koha/members/moremember.pl?borrowernumbe... (Walker) d) create an ill request (Interlibrary loans -> (Requests) -> New ILL request) and fill out mandatory data e) open dev tools (F12 on Firefox) and go to 'Place requests with partners' f) notice console error: Uncaught TypeError: can't access property "enabled", services[0] is undefined g) apply patch and reload page 'Place requests with partners' -> no error Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.