https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #36)
(In reply to Jonathan Druart from comment #23)
1. Changes are made in Koha/Schema/Result/OldIssue.pm, above the "DO NOT MODIFY THIS OR ANYTHING ABOVE!" line. Is it expected? Did you forget to attached the DB changes patch? If you wanted to add it after that line, why not adding the constraint at DB level?
Why not for Issue.pm?
We don't want to delete old issues just because a branch was removed. They are often needed for reporting purposes. It is presumed that current checkouts will be resolved before deleting a branch. That being said, it should be below the DO NOT line. That could be a rebasing accident.
2. -use base qw(Koha::Object); +use base qw(Koha::Checkout);
Is this really needed? Why? If so I think it must be moved to its own bug report, explaining why we need it and what it will bring. Also tests must be provided for such changes.
Note that both t/db_dependent/Koha/Account/Lines.t and t/db_dependent/Koha/Checkouts.t are passing without that change.
The allows old checkouts objects to inherit the same methods the checkouts object has, without the need to duplicate all the code. -- You are receiving this mail because: You are watching all bug changes.