https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Kyle M Hall (khall) from comment #7)
The idea is to not populate our classes with functions used solely for the purpose of data being accessible from notice templates. A small handful of generic accessors would be better then a multitude of specific ones that we'd need to maintain without knowing if they are even being used. I'll try to find some specific use cases.
Thanks for looking for those.
It's worth noting now that template renders are wrapped in a rolled back transaction.
Yeah, that helps with mutators but not accessors. Having read access to everything isn't brilliant.
An alternative would be to add public result and resultset accessors specifically instead of enabling access to all private accessors. Would that be a better solution?
No I don't think so. Notice templates should be simple. We're overcomplicating them. I get so many complaints about the notice editor, but Template::Toolkit makes a WYSIWYG pretty much impossible: bug 11583 -- You are receiving this mail because: You are watching all bug changes.