https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42292 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Failing QA for qa script failure we need to handle. Processing files [RUNNING] koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc [RUNNING] koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc [RUNNING] koha-tmpl/opac-tmpl/bootstrap/en/includes/greybox.inc [RUNNING] koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/greybox.inc [RUNNING] koha-tmpl/opac-tmpl/bootstrap/en/includes/js-date-format.inc [RUNNING] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/js-date-format.inc [RUNNING] koha-tmpl/opac-tmpl/bootstrap/en/includes/password_check.inc [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc ... Result: [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc FAIL valid_template cssinclude: not found [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/greybox.inc [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc [PASS] koha-tmpl/opac-tmpl/bootstrap/en/includes/js-date-format.inc [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc FAIL valid_template jsinclude: not found doc-head-close.inc uses [% PROCESS cssinclude %] (line 74) opac-bottom.inc uses [% PROCESS jsinclude %] (line 183). Those macros are defined by the calling module template via [% MACRO cssinclude BLOCK %]…[% END %] / [% MACRO jsinclude BLOCK %]…[% END %] and resolved at runtime through the caller's scope. When QohA's valid_template check renders each of these includes standalone there is no caller scope, so PROCESS does not find the macros and Template Toolkit throws. I tried a try catch around the PROCESS calls but that would alter runtime behaviour which we probably don't want. How should we fix it? -- You are receiving this mail because: You are watching all bug changes.