https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good :) However, sorry Joonas, but t/db_dependent/api/v1/holds.t is failing.. and ideally I'd love to see some basic tests for the new set_* methods introduced in Koha::Hold. They're trivial methods, but having a unit test that proves they correctly set the three fields for each of the methods will help prevent future regressions. Failing QA, but hopefully not for long. -- You are receiving this mail because: You are watching all bug changes.