https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #26)
(In reply to David Cook from comment #24)
(In reply to Katrin Fischer from comment #22)
I think that makes sense. Maybe instead of just a boolean flag we will want to note why kind of hold policy was overriden. If it was an override of the max holds it has a different effect (now too) as if it was an override of an item that is usually not holdable at all.
Hmm that's interesting. I don't know if we can capture that information. What's the different effect?
The "max holds" create no issues afaik as the hold will trigger and behave normally. But if you place a hold on an unholdable item, the hold won't trigger currently, so these are probably the ones we want to target here.
Ah, I understand now. Looking at CheckReserves, I was thinking we'd just group the policy ones together. Adding a note for the override could get burdensome. placerequest.pl would need some updates because it turns out that $can_override actually gets checked before CanBookBeReserved. So we'd need to change the precedence there. I think there also needs to be a parameter sent to indicate that an override has been requested. At the moment, the value of AllowHoldPolicyOverride is all that is used in order to trigger an override, and I guess the ability for someone to place an override in the first place. -- You are receiving this mail because: You are watching all bug changes.