https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at this, I have some questions: 1) As this makes a change to Patrons.pm, could/shoudl we have a unit test highlighting the effect of the change? 2) You check for the length using length() - I haven't found any other occurrences of this in the templates which made me wonder. Should we not just check if the value is > 0? length($no_issues_charge_guarantees) > 0 vs. $no_issues_charge_guarantees > 0 -- You are receiving this mail because: You are watching all bug changes.