https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43159 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #1 from David Cook <dcook@prosentient.com.au> --- On https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740#c74 I ask: "Move export to do_instance, remove three local's" Marcel, do you recall why you removed those locals? Because they were important. -- The thing is... "export PERL5LIB KOHA_HOME GIT_INSTALL" really doesn't need to be in _do_instance(). The "export" simply marks those variables as being exported. It has nothing to do with their values. Sometimes, we do things like 'export PERL5OPT="-d"' which is just a short-hand of 'export PERL5OPT; PERL5OPT="-d";'. But that's not what the above does. So it was fine where it was previously. Running "export PERL5LIB KOHA_HOME GIT_INSTALL" in _do_instance() is just needless repetition. -- And the problem with removing the "local" keyword is that it means these variables are used globally, so KOHA_HOME and GIT_INSTALL will overwrite previous values, while PERL5LIB just grows and grows, as I describe in bug 25778. -- You are receiving this mail because: You are watching all bug changes.