https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38291 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #82 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks Pedro, good catches. I have reworked this in follow-up patches. 1) Boolean filters. You are right that the integer typed parameters could not be used with the values the API returns. Declaring them as booleans was not enough, though: plain query parameters are matched with like and any value that is not empty counts as true, so ?is_local_hold_group=false (and =0, which already behaved that way) lists the groups that have the flag set. Generic list routes behave like this in general, for instance /patrons?protected=false lists the protected patrons. That deserves its own bug. /libraries, which this route follows, does not declare its boolean attributes either: they are filtered with q. Nothing uses the plain parameters here (the other bugs use q or a dedicated route), and every parameter we publish is a promise to keep it, so I have removed the attribute query parameters. q handles booleans correctly, for example q={"is_local_hold_group":false}, and the tests cover every flag with true and false. 2) hide_patron_info is now required, like the other flag columns. Non-blockers: removed the unused List::Util import, added format date-time to created_on and updated_on (both read only), and updated_on is no longer nullable, as its column is NOT NULL. created_on stays nullable, because its column is. -- You are receiving this mail because: You are watching all bug changes.