https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #11)
(In reply to Marcel de Rooy from comment #10)
(In reply to Marcel de Rooy from comment #5)
I think that it would be a very good thing to try caching here. What I am not sure about, is the theoretical possibility of getting wrong results if we would repeatedly ask for pickup_locations (while handling one request).
I would recommend to add the flush in Biblio->pickup_locations.
Apart from the syspref issue, this comment still got a bit out of sight. The theoretical(!) chance of calling it multiple times within one(!) request..
Multiple times is fine, we don't expect sysprefs to change within a single request - even for different bibs the results are not different for the same type of item
I had in mind to be depending on some patron attribute too, but it looks good. In pickup_locations and related calls, we only seem to actually use branchcode. -- You are receiving this mail because: You are watching all bug changes.