https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- I didn't fully test, but a few notes: 1 - Reserves.t fails after applying the patches 2 - The tests should use specific branches rather than deleting all rules/reserves - not a blocker 3 - check_if_existing_hold_matches_issuingrules should use the item and borrower methods rather than find - this will let us use table relationships and prefetch in the future and save db calls/hits 4 - Why do you unbless the item? 5 - the ReservesControlBranch code could be its own function - Koha::Hold::get_control_branch - not a blocker, but the tests should mock the pref and ensure behaviour works as expected with both settings -- You are receiving this mail because: You are watching all bug changes.