https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #46 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi Lari, the has_digest/takes_days keys from comment 37 break an existing test: 1) With the patch applied, run: prove t/db_dependent/api/v1/patrons.t 2) It fails at 'Default messaging preferences set correctly', since GetMessagingPreferences now also returns takes_days and has_digest 3) Delete lines 108 and 110 in C4/Members/Messaging.pm and run it again: it passes Nothing reads these two keys from GetMessagingPreferences, and t/Members_Messaging.t still passes without them, so I think they can simply go. -- You are receiving this mail because: You are watching all bug changes.