http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I did not check if the current code fixes all QA issues raised on comment 26. Additional remarks: 1/ In AddShare: you remove the 10 oldest entries and add 1? What I missed? 2/ AddShare: return !$dbh->err; => useless, $dbh->do insert returns the number of inserted rows. 3/ C4::VirtualShelves::ShelfPossibleAction Why do you use numeric code? It should be better to use an readable code. Moreover, these codes are used in the template. 4/ return if !defined($i) || !$i || $i eq '0E0'; #not found return 1; Could be replaced with return 1 if $i > 0 I think. 5/ It could be great to replace quotes with simple quotes around sql queries. 6/ (In reply to M. de Rooy from comment #31)
- The new letter should be added to others languages. I would really get rid of that restriction. I started some development on
(In reply to Jonathan Druart from comment #26) that (look for i18n). But unfortunately there is not that much support for it.
Yes, but this one cannot be pushed as it and this one is not marked as dependent on the other bug report. 7/ opac/opac-shareshelf.pl + for( 0..$#$alphabet ) It could be good to name the variable loop. -- You are receiving this mail because: You are watching all bug changes.