https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124003|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124753&action=edit Bug 28870: Use Email::Address to validate email addresses This patch adds a new dependency, Email::Address. It is used in Koha::Email to replace the current use of Email::Valid, which proved to be problematic when it comes to UTF-8 characters. Email::Address provides suitable regexes that -when used- keep our tests passing, but also deal better with UTF-8 data. To test: 1. Apply the regression tests patch 2. Notice the only change is that it tweaks a couple addresses so they contain umlauts and also have the "Description <address>" format that is used when sending carts. 3. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: Tests fail! Things die because Email::Valid doesn't like the from we passed. 4. Run: $ sudo apt install libemail-address-perl 5. Apply this patch 6. Repeat 3 => SUCCESS: Tests pass! 7. Try what is described in comment 1 => SUCCESS: Things are back to normal 8. Sign off :-D 9. Send cookies Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.